Convert text object to string. #31
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In chat with kattni, I mentioned that maybe this would affect how bytes objects were displayed. I was wrong about that (as of now, it's an error to pass a bytes object at all), but it does affect how lists and tuples of strings would be displayed. Before this PR, I don't think this necessarily means this PR shouldn't be merged, because to me it is very defensible that you could use "anything print()able" with a Label, even if the property is called "text". |
ladyada
approved these changes
Feb 2, 2020
|
yah folks should format() to hearts desire if they dont want str() |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 3, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.3.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#32 from kattni/fix-display-on-none > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#31 from kattni/convert-to-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for providing float object, such as acceleration or gyro data, without needing to convert to string in user code.