Managing addition of space at end of text #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping max_characters in properties and checking for length of text before adding a space to full_text.
|
Failed build on |
Checking for max_characters in constructor before adding space.
:: -> :
If this isn't set to force the update, self._last_animate_time sometimes gets stuck as -1 for a while, thus keeping the label from appearing.
Trying to get the ruff-format to succeed.
Matching style.
|
I think I figured it out. Working on fixing. |
Matching style.
FoamyGuy
approved these changes
May 27, 2025
There was a problem hiding this comment.
Thanks for the improvements @cinderblockgames!
This looks good to me, I tested successfully on a PyPortal Titano
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 28, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.13.4 from 2.13.3: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#88 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.28 from 3.4.27: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#39 from ilario/importerror_i2c Updating https://github.com/adafruit/Adafruit_CircuitPython_INA3221 to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_INA3221#8 from BZab/main Updating https://github.com/adafruit/Adafruit_CircuitPython_OPT4048 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_OPT4048#1 from FoamyGuy/use_properties Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#40 from FoamyGuy/saturation_effect_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.4.5 from 1.4.4: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#25 from FoamyGuy/displayio_api_update Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.4.5 from 1.4.4: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#27 from adafruit/update-display-modules Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#32 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.17 from 1.2.16: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#23 from FoamyGuy/displayio_api_update Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#25 from apzerafa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#22 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.3.0 from 3.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#220 from cinderblockgames/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 4.1.11 from 4.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#213 from justmobilize/204-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_OPT4048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping max_characters in properties and checking for length of text before adding a space to full_text.
This addresses the situation where the text is shorter or equal to the max_characters, which would add a space when shorter or start scrolling unnecessarily when equal to. Shorter isn't a big deal when left aligned, but it is noticeable when center or right aligned.