Skip to content

chore: allow use of bitmap_label without bitmaptools #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 31, 2023

in some cases, bitmaptools may not even be used - such as when displayio.Bitmap supports blit. in others, the module can run without bitmaptools as it has a fallback which works even if it's slower

fixes #192

tested by ensuring the circuitplayground express - which seems to omit bitmaptools - can still blit even if it's slow

in some cases, bitmaptools may not even be used - such as when
displayio.Bitmap supports blit.  in others, the module can run
without bitmaptools as it has a fallback which works even if
it's slower
@tannewt tannewt requested a review from FoamyGuy November 1, 2023 17:13
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @imnotjames

@FoamyGuy FoamyGuy merged commit 47539aa into adafruit:main Nov 1, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitmap_label errors if no bitmaptools module present
2 participants