Skip to content

Corrected typing to allow the color arguments to also take a Tuple #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

Corrected typing to allow the color arguments to also take a Tuple #176

merged 2 commits into from
Oct 14, 2022

Conversation

isacben
Copy link
Contributor

@isacben isacben commented Oct 12, 2022

Hi,

This PR solves Label can take Tuple[int, int, int] for color #175

Both parameters, color and backgrount_color can take either an int or a Tuple[int, int, int].

I tested label and bitmap_label with the Adafruit Feather RP2040 and the ST7789 display.

Please let me know if you have any comments!
Thanks!

tekktrik
tekktrik approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for following up on this!

@tekktrik tekktrik merged commit 6cf9f3c into adafruit:main Oct 14, 2022
@isacben
Copy link
Contributor Author

isacben commented Oct 14, 2022

Thank you! :)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 14, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eaa233b)
90e618e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.12 from 2.22.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#176 from isacben/label-type-annotations-fix
@tekktrik tekktrik mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isacben @tekktrik