Update simple example and usage example in readme #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter imports for pep 8
ladyada
requested changes
Jul 22, 2019
| text = "Hello world" | ||
| text_area = label.Label(terminalio.FONT, text=text) | ||
| text_area.x = 10 | ||
| text_area.y = 10 | ||
| board.DISPLAY.show(text_area) | ||
| while True: |
| text_area = label.Label(terminalio.FONT, text=text) | ||
| text_area.x = 10 | ||
| text_area.y = 10 | ||
| while True: |
|
Ah yes, sorry I misunderstood you the first time you described it. Having it do less makes sense to me! |
|
@makermelissa please review when you can |
makermelissa
approved these changes
Jul 22, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 22, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#6 from siddacious/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#16 from jtrip/master > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#14 from adafruit/ladyada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#12 from TG-Techie/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Nunchuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update simple example and usage example in readme, additional line after imports for pep 8.
As mentioned in #15 the simplest test example was blank although there was a good example in the readme file. I update the simple test file to match the usage example in the readme file and also put the display updating call in a
while True:loop so a user will be sure to see the output.I also added an additional blank line after the import statements in that file for pep 8 compliance. I also then copied that code to the usage example in the readme so that the update is reflected there.
I built the docs to verify the changes were reflected there, they were and I saw no other relevant aspect of the docs that needed updating. Even though the simple test file was blank the docs were already pointing to it, probably because there are so many of these wonderful libraries. 😄
If the pep 8 line is not welcome I can remove that and resubmit.