-
Notifications
You must be signed in to change notification settings - Fork 38
Directional label #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directional label #135
Conversation
# Conflicts: # adafruit_display_text/__init__.py
# Conflicts: # adafruit_display_text/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good @jposada202020. Thank you for all of your work on this!
I tested these changes using a modified simpletest script on
Adafruit CircuitPython 6.2.0-beta.3-182-g651f54b4c-dirty on 2021-03-14; Adafruit PyPortal with samd51j20
I tested all available directions and they were all working well for me.
I have a few suggestions if you think they would be good.
I'm also curious if you are willing to implement this functionality in the bitmap_label as well?
Yes, that is the idea, I like to do initial work on label and then extend to btmap_label once the feedback, revisions, request for changes and suggestions are in. |
…es. Error checking in both initial setup and setter module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @jposada202020 for this awesome new feature!
@FoamyGuy thanks for the review |
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.17.0 from 2.16.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#135 from jposada202020/directional_label > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#144 from lesamouraipourpre/docs
Current proposal will modify the display_text label capabilities. This will introduces four new text directions:
By default label will be in LTR mode, so old code will function. Text direction will be set-up by label_direction parameter.
All the parameters works, this include:
Known Issues:
In order to test with other languages, please use the following font
https://github.com/jposada202020/sandbox_display_text/blob/master/Helvetica-Bold-16.bdf
. I have manually added the correct characters in BDF file in order to example to work in the display.
Results
Test Code