Skip to content

Font examples #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Font examples #128

wants to merge 8 commits into from

Conversation

jposada202020
Copy link
Contributor

Change in the example to include a font available in the font directory in the library

@jposada202020
Copy link
Contributor Author

jposada202020 commented Mar 8, 2021

will close issue #127

@tannewt tannewt requested a review from a team March 8, 2021 23:01
@ladyada
Copy link
Member

ladyada commented Mar 9, 2021

@FoamyGuy wanna take a look (you're the text/label guru! :)

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jposada202020! The new font and the example it's used in look good to me.

This does also contain the changes from #121. So when this is merged it will supersede #121.

We'll also need to wait on #126 also if we want the actions to pass. I'll try to get that one merged tomorrow and then work on getting these others that aren't passing currently.

@jposada202020
Copy link
Contributor Author

@FoamyGuy No problem, Saturday I went to Free Fonts Rabbit hole, and the licenses in case you need something for the new guide. :). Yes. We would go back and majke the changes. I am planning to RE-submit all the PRs once the new library is approved

@FoamyGuy FoamyGuy mentioned this pull request Mar 10, 2021
@FoamyGuy
Copy link
Contributor

These changes were included in #133

@FoamyGuy FoamyGuy closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants