Skip to content

Fixed wrapping function when text length = maxchars #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2020
Merged

Fixed wrapping function when text length = maxchars #105

merged 3 commits into from
Dec 22, 2020

Conversation

makermelissa
Copy link
Collaborator

Fixes #104. This now works on short text when the max_chars is equal to the text words.

@makermelissa makermelissa requested a review from a team December 17, 2020 18:14
@FoamyGuy
Copy link
Contributor

Thanks for this fix, I will test this out tonight.

@FoamyGuy
Copy link
Contributor

I think we still have some kind of issue here. This line no longer throws an exception but it's also dropping the entire first word:

>>> print(wrap_text_to_lines("Hello World!", 5))
['Worl-', 'd!']

@makermelissa
Copy link
Collaborator Author

Ok, I made a small adjustment. It seems the Hello World was more of an edge case and I adjusted for that.

FoamyGuy
FoamyGuy approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@FoamyGuy FoamyGuy merged commit 8717242 into adafruit:master Dec 22, 2020
@makermelissa
Copy link
Collaborator Author

Thanks @FoamyGuy

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 22, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@644d4b7)
9eddf65 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#15 from bettse/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.10.1 from 2.10.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#105 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.1 from 1.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#56 from askpatrickw/bytesarray-split
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str index out of range for wrap_text_to_lines
2 participants
@makermelissa @FoamyGuy