add height and width properties for Rect and RoundRect #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmatch98
approved these changes
Nov 27, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 30, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.3.0 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#22 from tekktrik/feature/add-manual-offset > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.4.0 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#44 from FoamyGuy/size_properties > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
heightandwidthproperties to Rect and RoundRect which are helpful when trying to center the shape inside of some other "box". For example with this change and a new feature I'm working on in GridLayout you'll be able to add shapes to the GridLayout and anchor them within the cells however you'd like. i.e.:All testing was preformed using Blinka_DisplayIO. Definitely would appreciate if someone can test on a micro-controller with display connected.