Skip to content

Remove max_size parameter #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Usage Example
from adafruit_display_shapes.circle import Circle
from adafruit_display_shapes.roundrect import RoundRect

splash = displayio.Group(max_size=10)
splash = displayio.Group()
board.DISPLAY.show(splash)

color_bitmap = displayio.Bitmap(320, 240, 1)
Expand Down
Empty file modified adafruit_display_shapes/line.py
100755 → 100644
Empty file.
Empty file modified adafruit_display_shapes/polygon.py
100755 → 100644
Empty file.
Empty file modified adafruit_display_shapes/rect.py
100755 → 100644
Empty file.
Empty file modified adafruit_display_shapes/roundrect.py
100755 → 100644
Empty file.
4 changes: 1 addition & 3 deletions adafruit_display_shapes/sparkline.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ def __init__(
self._x = x
self._y = y

super().__init__(
max_size=self._max_items - 1, x=x, y=y
) # self is a group of lines
super().__init__(x=x, y=y) # self is a group of lines

def clear_values(self):
"""Removes all values from the _spark_list list and removes all lines in the group"""
Expand Down
Empty file modified adafruit_display_shapes/triangle.py
100755 → 100644
Empty file.
2 changes: 1 addition & 1 deletion examples/display_shapes_circle_animation.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
display = board.DISPLAY

# Make the display context
main_group = displayio.Group(max_size=2)
main_group = displayio.Group()

# Make a background color fill
color_bitmap = displayio.Bitmap(display.width, display.height, 1)
Expand Down
2 changes: 1 addition & 1 deletion examples/display_shapes_simpletest.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from adafruit_display_shapes.polygon import Polygon

# Make the display context
splash = displayio.Group(max_size=20)
splash = displayio.Group()
board.DISPLAY.show(splash)

# Make a background color fill
Expand Down
2 changes: 1 addition & 1 deletion examples/display_shapes_simpletest_magtag.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
display = board.DISPLAY

# Make the display context
splash = displayio.Group(max_size=20)
splash = displayio.Group()
display.show(splash)

# Make a background color fill
Expand Down
4 changes: 2 additions & 2 deletions examples/display_shapes_sparkline_simpletest.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@
#
# Note: In cases where display elements will overlap, then the order the elements
# are added to the group will set which is on top. Latter elements are displayed
# on top of former elemtns.
my_group = displayio.Group(max_size=1)
# on top of former elements.
my_group = displayio.Group()

# add the sparkline into my_group
my_group.append(sparkline1)
Expand Down
2 changes: 1 addition & 1 deletion examples/display_shapes_sparkline_ticks.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
# elements are added to the group will set which is on top. Latter elements
# are displayed on top of former elemtns.

my_group = displayio.Group(max_size=20)
my_group = displayio.Group()

my_group.append(sparkline1)
my_group.append(text_label1a)
Expand Down
4 changes: 2 additions & 2 deletions examples/display_shapes_sparkline_triple.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@
#
# Note: In cases where display elements will overlap, then the order the elements
# are added to the group will set which is on top. Latter elements are displayed
# on top of former elemtns.
my_group = displayio.Group(max_size=20)
# on top of former elements.
my_group = displayio.Group()

my_group.append(sparkline1)
my_group.append(text_label1a)
Expand Down