allow stroke parameter for Circle() #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were some pylint failures related to newer versions of pylint I think that came up in the actions for this PR some of them are unrelated to the changes I've made but I did go ahead and resolve them. polygon.py and triangle.py already disable circle and line both have super classes that provide the public methods that do things. If there is a more preferred way to handle any of these let me know and I can make a change to it. |
|
@makermelissa maybe try it out next week? |
makermelissa
approved these changes
Jul 1, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 2, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.2.2 from 3.2.1: > Fix discord badge Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1305 to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1305#10 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.3.2 from 3.3.1: > Fix discord badge Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.3.4 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#20 from jepler/fix-formatting Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 1.4.0 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#15 from FoamyGuy/support_stroke_on_circle Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.1.3 from 4.1.2: > Pass in descriptor in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.2 from 0.11.1: > Link to learn guide page about bitmaps Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BH1750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circle is extending RoundRect which already has support for
stroke. It wasn't being accepted as a parameter on Circle__init__()however so it was not working with Circle.This change accepts
strokewith a default of1and passes it through to the super class RoundRect constructor.