Skip to content

Allow for changing label of button #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Mar 24, 2019

mostly a refactor, so button text can change

@ladyada ladyada requested a review from makermelissa March 24, 2019 23:28
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great with my calculator example.

@makermelissa makermelissa merged commit 8af076e into adafruit:master Mar 25, 2019
@ladyada
Copy link
Member Author

ladyada commented Mar 25, 2019

huzzah! wanna bump both?

@makermelissa
Copy link
Collaborator

Yep, was just about to do that.

@makermelissa
Copy link
Collaborator

I should note that while this update didn't break the examples, the examples should probably be updated to work with Beta 5, which is why I approved it. I can create an issue for that.

@makermelissa
Copy link
Collaborator

@kattni, could you fix the API keys for https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes and https://github.com/adafruit/Adafruit_CircuitPython_Display_Button when you get a chance? Both are failing to release on travis.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 25, 2019
@kattni
Copy link

kattni commented Mar 26, 2019

@ladyada Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants