Skip to content

fix for https://github.com/adafruit/circuitpython/issues/4956 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2021
Merged

fix for https://github.com/adafruit/circuitpython/issues/4956 #7

merged 8 commits into from
Jul 9, 2021

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Jul 9, 2021

now does differnet htings for pre-7!

@ladyada ladyada requested a review from jepler July 9, 2021 02:54
jepler
jepler reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my program I had to change my code from

display = adafruit_displayio_sh1107.SH1107(display_bus, width=WIDTH, height=HEIGHT, rotation=180)

to

display = adafruit_displayio_sh1107.SH1107(display_bus, width=WIDTH, height=HEIGHT, rotation=270)

to get the display how I wanted it. Is this expected? Won't it mean there's still a change required to go from 6 to 7 (which is probably fine, it's a major version)?

@jepler
Copy link
Contributor

jepler commented Jul 9, 2021

.. can the lib constructor take in rotation (default: rotation=0) and in the 7.0+ case use (rotation + 90) % 360?

jepler
jepler reviewed Jul 9, 2021
View reviewed changes
adafruit_displayio_sh1107.py
b"\xaf\x00" # DISPLAY_ON
)
# we fixed sh110x addressing in 7, so we have slightly different setups
if sys.implementation.version[0] < 7:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm .. it seems like this lib is also used on standard python3 (is in pypi) where sys.implementation.version is currently 3. I guess this means that python3 also keeps using the old behavior, which is fine for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont even think that oleds are supported in blinka? or this special oled method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but it's in pypi. https://pypi.org/project/adafruit-circuitpython-displayio-sh1107/

I think it's fine, since 3<7 so this doesn't change anything on blinka.

@ladyada
Copy link
Member Author

ladyada commented Jul 9, 2021

.. can the lib constructor take in rotation (default: rotation=0) and in the 7.0+ case use (rotation + 90) % 360?

i could if you prefer that?

@jepler jepler self-requested a review July 9, 2021 15:34
jepler
jepler approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested with unmodified calculator program and the last alpha release and all is well!

@jepler jepler merged commit 980127d into adafruit:main Jul 9, 2021
@ladyada
Copy link
Member Author

ladyada commented Jul 9, 2021

ok FYI @makermelissa i dont know we support this oled but we may have to tweak this if we do

@makermelissa
Copy link
Collaborator

If it's the same OLED as the one in https://www.adafruit.com/product/4650, then I think we do support it.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 17, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5b7e4de)
874fec5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#7 from ladyada/main
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#6 from lesamouraipourpre/max-size
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.2.0 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#12 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.4.0 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#21 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#15 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.9 from 1.3.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#22 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#11 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#27 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#10 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 1.3.0 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#14 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.3.0 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#16 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#11 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.7 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#10 from lesamouraipourpre/ondiskbitmap-changes
  > Moved default branch to main
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#2 from lesamouraipourpre/ondiskbitmap-changes
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#5 from lesamouraipourpre/ondiskbitmap-changes
  > Moved CI to Python 3.7

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.0 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#15 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.0 from 1.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#23 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.20.0 from 2.18.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#154 from lesamouraipourpre/refactor

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#20 from lesamouraipourpre/ondiskbitmap-changes
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#19 from lesamouraipourpre/max-size
  > Moved default branch to main

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#36 from lesamouraipourpre/patch-1
  > Moved default branch to main
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#35 from 4dcu-be/master
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.1.0 from 5.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#84 from PhearZero/patch-1
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.3.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#45 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#43 from FoamyGuy/pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.3.0 from 2.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#23 from lesamouraipourpre/max_size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.2.6 from 2.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#32 from dunkmann00/revert-31-slice-fix
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 2.2.0 from 2.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_turtle#24 from lesamouraipourpre/max-size
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Pixelbuf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladyada @jepler @makermelissa