Add a display_offset parameter to SH1107. #5
Conversation
The current init_sequence assumes it is connected to the Adafruit FeatherWing 128x64 OLED screen. This parameter provides a way to set value provided to the Display Offset (D3) command. The value of this cannot be calculated from the size of the screen (except in the maximum case) as a manufacturer can choose where in the 128x128 grid they wire up their screen to. The default value has been kept to the FeatherWing value of 0x60 so this should not be a breaking change. Constants have been included for: * Adafruit FeatherWing 128x64 OLED * Pimoroni Mono 128x128 OLED
|
@lesamouraipourpre Thanks I noticed that you mentioned that this is not a breaking change. I could test that @kattni comments rearding this. Let me know and I could proceed to test and give my final review. Thanks |
|
@jposada202020 As long as it doesn't break support for the Adafruit SH1107 display, it's fine to add support for the Pimoroni display. The important thing is that it defaults to the current settings so that all of the associated code does not need to be changed. |
|
Thanks I will test then tonight, and make my review if any, or merged... Thanks... |
There was a problem hiding this comment.
This was tested on
Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather M4 CAN with same51j19aUsing a Adafruit 128x64 OLED FeatherWing and the displayio_sh1107_simpletest.py example
LIbrary worked as expected, Changes were verified. Displays default to Adafruit Display as described in the PR
Thanks for for improving the documentation also.
Looks Good To me
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#3 from jposada202020/improxing_docs > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.3.0 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#21 from jposada202020/separating_properties Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#5 from lesamouraipourpre/display_offset > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#17 from jposada202020/correcting_typo Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.2.0 from 4.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#41 from jposada202020/adding_temperature_property Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.2.0 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#10 from codenio/feature/general_call Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.3.0 from 1.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#18 from sheimers/master > "Increase duplicate code check threshold "
The current init_sequence assumes it is connected to the Adafruit FeatherWing 128x64 OLED
screen. This parameter provides a way to set value provided to the Display Offset (D3)
command. The value of this cannot be calculated from the size of the screen (except in
the maximum case) as a manufacturer can choose where in the 128x128 grid they wire up
their screen to.
The default value has been kept to the FeatherWing value of 0x60 so this should not be a
breaking change.
Constants have been included for: