Skip to content

Pass filename to OnDiskBitmap to avoid closed file problem #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

dhalbert
Copy link
Contributor

Fixes problem reported by user in https://forums.adafruit.com/viewtopic.php?f=60&t=185540.
Tested on a PyPortal with the Touch Deck code.

  • Pass filename to OnDiskBitmap instead of a file handle.
  • Remove pre-CP6 compatibility code.

@dhalbert dhalbert requested review from FoamyGuy and a team November 24, 2021 22:17
@dhalbert dhalbert force-pushed the ondiskbitmap-use-filename branch from 25c8b87 to 03bd012 Compare November 24, 2021 22:22
@dhalbert dhalbert merged commit f982127 into adafruit:main Nov 24, 2021
@dhalbert dhalbert deleted the ondiskbitmap-use-filename branch November 24, 2021 22:26
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants