-
Notifications
You must be signed in to change notification settings - Fork 15
Update grid_layout.py #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added the ability to change the divider line color
@GingerIndustries thanks for adding this functionality. This is currently failing pylint due to Some of the attributes could be collapsed into a dictionary or other object that can hold multiple things. But it seems to me that this would make the code more complex for the purpose of pleasing pylint. Personally I think it would be okay to disable the |
It probably doesn't matter, as this will be compiled to an .mpy regardless. I could make the changes if you want. |
@GingerIndustries we will have to getting passing the CI checks one way or another before it can be merged. Even though the resulting library will get compiled to mpy we still run pylint and a few other checks on the .py version of the code using github actions. Go ahead and add the pylint disable comment for that specific check. Let me know if you have any trouble, or need help with that. |
Okay, it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Tested successfully on a PyPortal with a modified the gridlayout_dividers script in the examples directory.
I tested hex colors i.e. 0xFF00FF
as well as tuple colors i.e (255, 0, 255)
and both work as expected. I think internally displayio.Palette allows both to work in this case without any specific code needed in this library.
Thanks for adding this new functionality @GingerIndustries
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.14.0 from 1.13.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#53 from GingerIndustries/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#56 from rsbohn/dexter1126
Nice! Thanks, |
Added the ability to change the divider line color