-
Notifications
You must be signed in to change notification settings - Fork 15
Dial gauge #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dial gauge #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! thanks for adding it. I will take a closer look and test it out tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really amazing! thanks for working on this @kmatch98
I have a few minor suggestions, but overall this is looking pretty good to me.
I tested the new example, and a few variations on it with:
Adafruit CircuitPython 6.2.0-beta.3-36-g103632f44 on 2021-03-07; Adafruit PyPortal with samd51j20
I also built locally and checked out the new sections of the docs pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in this is looking good to me now. I noticed one small typo, and have a question about the docs pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-tested the latest version with a PyPortal. It's working well.
This looks good to me. Thanks again for all of your work on this @kmatch98
so cute! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#13 from kmatch98/dial_gauge
Adds a dial gauge to the CircuitPython Widget family. Includes some brief documentation with images showing some of the main features.