Skip to content

Dial gauge #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 18, 2021
Merged

Dial gauge #13

merged 12 commits into from
Mar 18, 2021

Conversation

kmatch98
Copy link
Contributor

dial

Adds a dial gauge to the CircuitPython Widget family. Includes some brief documentation with images showing some of the main features.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! thanks for adding it. I will take a closer look and test it out tomorrow.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really amazing! thanks for working on this @kmatch98

I have a few minor suggestions, but overall this is looking pretty good to me.

I tested the new example, and a few variations on it with:

Adafruit CircuitPython 6.2.0-beta.3-36-g103632f44 on 2021-03-07; Adafruit PyPortal with samd51j20

I also built locally and checked out the new sections of the docs pages.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this is looking good to me now. I noticed one small typo, and have a question about the docs pages.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-tested the latest version with a PyPortal. It's working well.

This looks good to me. Thanks again for all of your work on this @kmatch98

@FoamyGuy FoamyGuy merged commit 0b0288a into adafruit:main Mar 18, 2021
@ladyada
Copy link
Member

ladyada commented Mar 18, 2021

so cute!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants