add touchio as an optional type of input #8
Conversation
|
@dastels Please review and test this. I will deal with the documentation building failure if we intend to move forward with the PR. Thanks! |
There was a problem hiding this comment.
I tested this version of the adafruit_debouncer library using a CPX device with touchio working on pin A1 For testing I modified the Usage Example in the readme to include setting up the touchio pin. Everything is working as expected, after modifying the example I am seeing all of the correct print statements when using the touch pin. I also verified that DigitalInOut is still working as expected with the modified library by testing on one of the build-in buttons D4
|
@iraytrace There are documentation building issues on this PR that I cannot easily edit. If you are available, please ping me directly and I can help you walk though it. Otherwise, I will have someone submit your changes as a new PR with the documentation fixes included. |
| @@ -48,6 +48,7 @@ | |||
| import time | |||
| import digitalio | |||
| from micropython import const | |||
| import touchio | |||
There was a problem hiding this comment.
this will stop the module from being importable on boards without touchio
| @@ -62,7 +63,7 @@ def __init__(self, io_or_predicate, interval=0.010): | |||
| :param int interval: bounce threshold in seconds (default is 0.010, i.e. 10 milliseconds) | |||
| """ | |||
| self.state = 0x00 | |||
| if isinstance(io_or_predicate, digitalio.DigitalInOut): | |||
| if isinstance(io_or_predicate, (digitalio.DigitalInOut, touchio.TouchIn)): | |||
There was a problem hiding this comment.
could this be changed to 'if hasattr(io_or_predicate, 'value')` ? This would mean that the import of touchio was not needed, but would also make it work with other io types, such as on a seesaw.
I find sometimes I wanted to use touchio inputs with Debouncer. Simple check for that type allows this.