Skip to content

Add type annotations to adafruit_dash_display #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2023

Conversation

julianaklulo
Copy link
Contributor

@julianaklulo julianaklulo commented Apr 25, 2023

Adds type annotations to library adafruit_dash_display.py, closes #3.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @julianaklulo!

I have a suggested change, and perhaps a few others pending the results of some additional testing.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of this is looking good to me. I tested it successfully on a FunHouse with the simpletest in this repo examples dir.

Thanks again for taking this on!

@FoamyGuy FoamyGuy merged commit 3b5bcc0 into adafruit:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants