Skip to content

Replace depreciated .show() #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Replace depreciated .show() #15

merged 1 commit into from
Nov 2, 2023

Conversation

RetiredWizard
Copy link
Contributor

fixes #14

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples set the .root_group to None and them figure out the root_group and set the root_group to that thing. I'm thinking the None assignment is unnecessary?

@RetiredWizard
Copy link
Contributor Author

RetiredWizard commented Nov 2, 2023

Since I'm not actually testing the code, I'm a little concerned about making logic changes. One of the root_group=None lines has a sleep following it. Do you think it's possible removing the screen blanks may change the way the display behaves, especially on slower microcontrollers/displays (maybe e-ink)?

When I went back and looked through the example code this time, I did notice that at least one of the examples is using a secrets file rather than settings.toml. I think I should go ahead and add logic to check if the settings.toml is there and if it is, use that instead. The secrets.py should probably stay in as a fall back since the examples may be referenced by learn guides that haven't been updated for settings.toml?

@dhalbert
Copy link
Contributor

dhalbert commented Nov 2, 2023

Yes, that's the problem with looking at old code 😄

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to leave the Nones in for now, since the code will still work.

@RetiredWizard
Copy link
Contributor Author

I'll submit a second PR to this library for the secrets.py fix. I think this one can be merged.

@dhalbert dhalbert merged commit b806b4d into adafruit:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert .show() to .root_group = for CircuitPython 9
2 participants