Skip to content

Converted strings to f-strings, added Hub class parameter descriptions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2023
Merged

Converted strings to f-strings, added Hub class parameter descriptions #13

merged 6 commits into from
Jul 18, 2023

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Jul 18, 2023

Fixes #10.

Converted two strings to f-strings. Added Hub class parameter descriptions.

dhalbert
dhalbert requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Made a few suggestions about naming and documentation.

Also, there are two files in examples/ that will need updating with the new io_mqtt name.

dhalbert
dhalbert approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@dhalbert dhalbert merged commit 1b3d01b into adafruit:main Jul 18, 2023
@kattni kattni deleted the f-strings-and-params branch July 18, 2023 20:12
@kattni kattni restored the f-strings-and-params branch July 18, 2023 22:44
@kattni kattni deleted the f-strings-and-params branch July 18, 2023 22:49
@kattni kattni mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Using F-Strings
2 participants
@kattni @dhalbert