correct register width when retrieving calibration register (fixes #30) #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't speak to the correctness of the change, but I can say that with this patch my gemma M0 that was previously failing to import ds3231 now succeeds :). Thanks for the fix @MattyJeronimo ! |
jepler
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Thank you @MattyJeronimo and thanks for testing @travisby !
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 17, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#2 from mcauser/patch-1 > Removed deprecated pylint disable 'bad-whitespace' Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.2 from 3.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#56 from yeyeto2788/fix_issue_32 Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.2 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#32 from MattyJeronimo/mjeronimo/fix-cortex-m0-register-width-error Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.6 from 3.4.5: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#26 from WizardTim/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 1.0.2 from 1.0.1: > fixing typo and adding i2c stop for register read Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#33 from FoamyGuy/pcf_examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register width parameter of call to i2c_bits.RWBits specifies the width of the register in bytes. However, in the following call, register width is passed as 8.
_calibration = i2c_bits.RWBits(8, 0x10, 0, 8, signed=True)This results in an 8 byte register (64 bit). This fails on feather m0 adalogger because maximum integer value for a python int on this platform is (2^30)-1
The register should only be 1 byte, the 8 is probably a typo because the other arguments passed are in bits.
Fixes: #30