Add asynchhronous functions #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new functions: start a conversion and return immediately, and read temperature.
|
@tannewt this is a good opportunity to come up with api naming for async sensor reading. this is gonna come up more & more |
Fix newbie mistake s/if/while/ and neater output; also force 12 bit resolution to better demonstrate the operation.
|
I think this naming is fine for now. There is still discussion on adafruit/circuitpython#1380 about it. @dhalbert may have other ideas. |
|
I'm not sure why the Travis build failed. The only problem I see in the build log is pylint "trailing whitespace" on line 124. But there aren't 124 lines in adafruit_ds18x20.py. When I run pylint locally, I get two refactor warnings in the existing code (that I didn't touch). |
|
make sure you are looking at the right code, the file def has 124 lines |
|
OK, removed extra blanks from line 124. |
Removed trailing spaces to resolve PyLint warning.
|
You’re welcome. Now, what happens to the issue #11 ? Should it be closed? By whom?
Thanks
--Louis
From: Scott Shawcroft <[email protected]>
Sent: August 7, 2019 6:08 PM
To: adafruit/Adafruit_CircuitPython_DS18X20 <[email protected]>
Cc: Louis Bertrand <[email protected]>; Author <[email protected]>
Subject: Re: [adafruit/Adafruit_CircuitPython_DS18X20] Add asynchhronous functions (#12)
@tannewt approved this pull request.
Looks great! Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12?email_source=notifications&email_token=ACRQSCVEBNKPGHR2JAIDNG3QDNBSTA5CNFSM4IIJLKA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCA5EQHA#pullrequestreview-272255004>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACRQSCVRRUOV3Y6VIS5YTBTQDNBSTANCNFSM4IIJLKAQ>.
…________________________________
This message is intended only for the named recipients. This message may contain information that is confidential or exempt from disclosure under applicable law. Any dissemination or copying of this message by anyone other than a named recipient is strictly prohibited. If you are not a named recipient or an employee or agent responsible for delivering this message to a named recipient, please notify us immediately, and permanently destroy this message and any copies you may have. Warning: Email may not be secure unless properly encrypted.
|
|
I've closed it. Next time you can use a keyword in a commit message to have the issue closed automatically when the commit is merged: https://help.github.com/en/articles/closing-issues-using-keywords Thanks! |
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 17, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.10.3 from 1.10.2: > Merge pull request adafruit/Adafruit_CircuitPython_ADXL34x#9 from hartzell/patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.3.2 from 2.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#27 from ncguk/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.4 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#69 from caternuson/iss68 Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.2.0 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#12 from LBertrandDC/asynchronous-functions Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#9 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.4.0 from 3.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#34 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_GPS#31 from dherrada/master > Merge branch 'master' into master Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU21D to 0.9.0 from 0.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_HTU21D#5 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.4.0 from 3.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#27 from tannewt/remove_debug > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#25 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MCP3xxx#14 from brentru/update-examples Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#20 from ntoll/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#6 from romanakozak/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.1.0 from 1.0.0: > added tap detection. Couldn't make latching work Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 0.1.1 from 0.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#5 from ntoll/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.0.1 from 1.0.0: > fixed typos for (yet to be used) fault queue length Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#11 from WoefulDerelict/periodic_data_acquisition > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#10 from WoefulDerelict/temperature_docstring_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.6.4 from 2.6.3: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#29 from adafruit/tannewt-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#10 from caternuson/README_update Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#6 from demophoon/add-blinka-to-requirements-txt Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.2.0 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#10 from aaronaverill/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#8 from schlafa/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.9.2 from 0.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#21 from fionawhim/rle-bmp > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#19 from cogliano/patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#18 from cogliano/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#17 from deshipu/master > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#15 from tannewt/fix_one_bit Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.1.5 from 0.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#11 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#20 from adario7/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#11 from jerryneedell/jerryn_bytes Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.3.0 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#14 from hexthat/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 2.0.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#46 from jepler/issue45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new functions: start a conversion and return immediately, and read temperature.