Skip to content

adafruit_ds1307 module does not respect user-changed values for Square Wave output #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2022
Merged

adafruit_ds1307 module does not respect user-changed values for Square Wave output #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae59601
Updated adafruit_ds1307.py to allow Square Wave settings
coplate May 20, 2022
ceeef55
Merge pull request #1 from coplate/coplate-patch-allow-square-validation
coplate May 20, 2022
8dd7fea
Update adafruit_ds1307.py
coplate May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions adafruit_ds1307.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,21 @@ class DS1307:
def __init__(self, i2c_bus):
self.i2c_device = I2CDevice(i2c_bus, 0x68)

# Try and verify this is the RTC we expect by checking the rate select
# control bits which are 1 on reset and shouldn't ever be changed.
# Try and verify this is the RTC we expect by checking constant fields.
# These fields are described as "0 = Always reads back as 0." in spec.
buf = bytearray(2)
buf[0] = 0x07
with self.i2c_device as i2c:
i2c.write_then_readinto(buf, buf, out_end=1, in_start=1)

if (buf[1] & 0b00000011) != 0b00000011:
if (buf[1] & 0b01101100) != 0b00000000:
raise ValueError("Unable to find DS1307 at i2c address 0x68.")

buf[0] = 0x03
with self.i2c_device as i2c:
i2c.write_then_readinto(buf, buf, out_end=1, in_start=1)

if (buf[1] & 0b11111000) != 0b00000000:
raise ValueError("Unable to find DS1307 at i2c address 0x68.")

@property
Expand Down