Skip to content

Sure, loop on all 123. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Sure, loop on all 123. #14

merged 1 commit into from
Mar 22, 2019

Conversation

caternuson
Copy link
Contributor

Fix for #13. Worth testing - effect 118 is several seconds long which made last effects essentially not play. Simple fix for that as well. Tested and all good.

Adafruit CircuitPython 3.1.2 on 2019-01-07; Adafruit ItsyBitsy M0 Express with samd21g18
>>> import drv2605_simpletest
Playing effect #1
Playing effect #2
Playing effect #3
### SNIP ###
Playing effect #117
Playing effect #118
Playing effect #119
Playing effect #120
Playing effect #121
Playing effect #122
Playing effect #123

drv2605_test

@caternuson caternuson requested a review from a team March 21, 2019 20:36
@ladyada ladyada merged commit b89e652 into adafruit:master Mar 22, 2019
@ladyada
Copy link
Member

ladyada commented Mar 22, 2019

werd

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#14 from caternuson/iss13

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#30 from jerryneedell/jerryn_aio_post

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#16 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.3.1 from 2.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#14 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RA8875 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#8 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_RA8875#7 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_TPA2016, Adafruit_CircuitPython_Display_Button, Adafruit_CircuitPython_Display_Shapes
@caternuson caternuson mentioned this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants