Skip to content

Change asserts to raised errors. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caternuson opened this issue Oct 5, 2018 · 2 comments
Closed

Change asserts to raised errors. #8

caternuson opened this issue Oct 5, 2018 · 2 comments
Assignees
@caternuson
Labels
good first issue hacktoberfest

Comments

@caternuson
Copy link
Contributor

Change the assert checks to raise an appropriate Error along with helpful message.
@caternuson caternuson self-assigned this Oct 5, 2018
@process1183
Copy link
Contributor

I'll work on this one.

@caternuson
Copy link
Contributor Author

Awesome. Looks like you're up for #9 also. Please do these as separate PR's.

@caternuson caternuson mentioned this issue Oct 5, 2018
Closed
caternuson added a commit that referenced this issue Oct 5, 2018
@caternuson
Merge pull request #10 from process1183/asserts
0429b55 
Raise exceptions instead of using assert checks (fixes #8).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caternuson caternuson

Labels
good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caternuson @process1183