Skip to content

Stepper broken due to change in Adafruit_CircuitPython_Motor #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caternuson opened this issue Mar 13, 2019 · 4 comments
Closed

Stepper broken due to change in Adafruit_CircuitPython_Motor #15

caternuson opened this issue Mar 13, 2019 · 4 comments

Comments

@caternuson
Copy link
Contributor

Started here:
https://forums.adafruit.com/viewtopic.php?f=8&t=148916
and verified. This PR:
https://github.com/adafruit/Adafruit_CircuitPython_Motor/pull/23/files
changed the way the frequency value is checked. It now throws an Error instead of changing it.

The stepper setup here needs to set frequency on its PWMOut objects. This might be made easier if frequency could be passed in to PWMOut constructor:
https://github.com/adafruit/Adafruit_CircuitPython_seesaw/blob/master/adafruit_seesaw/pwmout.py#L29

@ladyada
Copy link
Member

ladyada commented Mar 14, 2019

@siddacious heya can you check this and revert ? ive been swamped and unable to test

@siddacious
Copy link

Yup, I'll take a look.

@siddacious
Copy link

OOf. My bad. :|

@ladyada
Copy link
Member

ladyada commented Mar 19, 2019

hiya this should be all fixed now!

@ladyada ladyada closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants