-
Notifications
You must be signed in to change notification settings - Fork 11
Stepper broken due to change in Adafruit_CircuitPython_Motor #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@siddacious heya can you check this and revert ? ive been swamped and unable to test |
Yup, I'll take a look. |
OOf. My bad. :| |
siddacious
added a commit
to siddacious/Adafruit_CircuitPython_Motor
that referenced
this issue
Mar 14, 2019
This reverts commit a889448, reversing changes made to 7f93c2a. (adafruit/Adafruit_CircuitPython_Crickit#15)
hiya this should be all fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Started here:
https://forums.adafruit.com/viewtopic.php?f=8&t=148916
and verified. This PR:
https://github.com/adafruit/Adafruit_CircuitPython_Motor/pull/23/files
changed the way the
frequency
value is checked. It now throws an Error instead of changing it.The stepper setup here needs to set
frequency
on itsPWMOut
objects. This might be made easier iffrequency
could be passed in to PWMOut constructor:https://github.com/adafruit/Adafruit_CircuitPython_seesaw/blob/master/adafruit_seesaw/pwmout.py#L29
The text was updated successfully, but these errors were encountered: