volume

[hexthat]

No description provided.

[hexthat]

from adafruit_circuitplayground.express import cpx

newvol = -(2**12)

cpx.play_tone(220, 2, newvol)

tone example with volume

[kevinjwalters]

Would be useful to document the volume variable including the appropriate range of values and the default in the docstring? What happens if you go too loud, does it throw an exception?

Are there any precedents for volume variables in the codebase? Are there any solid plans for doing this elsewhere, e.g. there might already be some future ideas on extending the new audioio.Mixer ?

BTW, there's mention of 0.0 to 1.0 in adafruit/circuitpython#1306

[hexthat]

yes something can be done like that around lines 566 to 569, but im not sure how to do that.... think i could use something like this for louder but not sure about less quite

int(255* max( 0, min( 1, (1-value) )) )

looks like most that other stuff is for .wav files

[kevinjwalters]

How does this handle going "too loud", i.e. exceeding the permited range on values? I note CircuitPython 4.x has changed behaviour on values that are out of range for array.array:

bytearray, array.array, and int.to_bytes() now check for values that are too large to fit. This matches CPython behavior. Thanks to godlygeek.

[kevinjwalters]

An example of errors from exceeding the 16 bit limits:

• sine_wave likely to generate value too large for "H" array.array Adafruit_CircuitPython_Waveform#9
• https://forums.adafruit.com/viewtopic.php?f=60&t=153174

I'd imagine bad things are likely to happen to values to, even the DSP-esque saturate approach isn't nice here.

[jepler]

As written, won't this cause the first volume used to apply to all samples until a restart?

[kattni]

@hexthat There is new discussion on this PR. As well, the library has been entirely restructured since you submitted this, and therefore inclusion of your change will require a significant change to this PR. If this is something you're still interested in seeing included, it may make more sense to submit a new PR to the newly structured library, unless you're comfortable with advanced git and are able to rebase locally. Let me know if you have a preference, and I will leave this PR open or close it accordingly. Thanks!

[kattni]

I'm going to close this PR. If you still wish to add this feature, please consider submitting a new PR in this case, as the library was entirely restructured since it was submitted. These changes would now be added to circuit_playground_base.py and will require testing on both Circuit Playground Express and Bluefruit.