Skip to content

added examples folder and .py files #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2018
Merged

Conversation

mrmcwethy
Copy link
Collaborator

#adafruit/circuitpython#493

added examples files for acceleration, pixels, shake, tapdetect, tone, and touched.

@kattni
Copy link
Contributor

kattni commented Jan 23, 2018

We may want to consider also including a simpler tap detection example. The purpose of that example was to show how single and double tap can be used together, it wasn't meant to be the typical usage of it. I think it's fine to include it, I simply think we should have a more likely use-case.

@mrmcwethy
Copy link
Collaborator Author

@kattni i can do that.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in tapdetectsimple.py filename (currently tapodetectsimple.py) should be fixed.

Tested every example successfully. Thanks for doing this! Consider suggested updates, otherwise ready to merge.

@@ -0,0 +1,5 @@
from adafruit_circuitplayground.express import cpx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an import time and time.sleep(0.1) at least into this one so it is more reasonable to read.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@kattni
Copy link
Contributor

kattni commented Jan 23, 2018

Looks great, thank you!

@kattni kattni merged commit 4df91b8 into adafruit:master Jan 23, 2018
@mrmcwethy
Copy link
Collaborator Author

@kattni Thanks for the review

tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 24, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#28 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 1.2.0 from v1.0.1:
  > added examples folder and .py file.  Also change read_into to readinto (adafruit/Adafruit_CircuitPython_DS1307#3)
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#2 from tannewt/lint
  > Update for I2C BusDevice read/write rename.
  > Update for nativeio split.
  > Add a note about the dependencies.
  > Add badges for docs and Gitter.
  > Switch to the Register library (https://github.com/adafruit/Adafruit_CircuitPython_Register)

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.1.0 from 1.0.0:
  > added examples folder and .py file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants