Added shake detection #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Nov 28, 2017
|
|
||
| while True: | ||
| if shake(): | ||
| print("Shake detected!") |
There was a problem hiding this comment.
I think this is missing an indent.
|
|
||
| while True: | ||
| if shake(shake_threshold=20): | ||
| print("Shake detected more easily than before!") |
| from adafruit_circuitplayground.express import cpx | ||
|
|
||
| while True: | ||
| if shake(): |
| @@ -88,6 +88,39 @@ def acceleration(self): | |||
| """ | |||
| return self._lis3dh.acceleration | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
I don't think this should be a property because the implementation sleeps. So, remove property here and below return self._lis3dh.shake(). Right now you are actually returning the underlying function as the value of the property and then calling it. After the changes you'll return the value itself.
tannewt
approved these changes
Nov 29, 2017
|
Looks great! Thank you! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 8, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 0.9.0 from 0.8.1: > Added error to cpx.shake for incompatible CircuitPython versions (adafruit/Adafruit_CircuitPython_CircuitPlayground#19) > Removed unnecessary lis3dh lines from init > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#17 from chickadee-tech/lint > Added .frozen to sys path to prefer frozen modules > Added shake detection (adafruit/Adafruit_CircuitPython_CircuitPlayground#15) > Doc updates, global brightness included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated typo as well.