Linted. #111
Merged
Linted. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithTheEE
reviewed
Nov 5, 2021
| @@ -161,7 +161,9 @@ def play_mp3(self, file_name): | |||
| with self._audio_out( | |||
| board.SPEAKER | |||
| ) as audio: # pylint: disable=not-callable | |||
| mp3file = audiomp3.MP3Decoder(open(file_name, "rb")) | |||
| mp3file = audiomp3.MP3Decoder( | |||
| open(file_name, "rb") # pylint: disable=consider-using-with | |||
There was a problem hiding this comment.
Looks good--Just curious why are we not using with open(...) here?
There was a problem hiding this comment.
I didn't realise you could do nested withs! Fixing now.
KeithTheEE
approved these changes
Nov 5, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 12, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.0.2 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#112 from kattni/requirements > Updated readthedocs file > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#111 from kattni/linting > Disabled unspecified-encoding pylint check > PATCH Pylint and readthedocs patch test > add docs link to readme > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.