Acceleration implemented. #11
Conversation
| self._x, self._y, self._z = self._lis3dh.acceleration | ||
|
|
||
| @property | ||
| def acceleration_x(self): |
There was a problem hiding this comment.
Why do you have x, y and z as separate properties? I was expecting a single acceleration property that just returns self._lis3dh.acceleration.
There was a problem hiding this comment.
It was necessary to use separate properties to make them work in the code as acceleration_x, acceleration_y and acceleration_z. Otherwise we're typing cpx.x, cpx.y, and cpx.z which I thought could be a little unclear. As well, since including something that = self._lisd3h.acceleration is required in whatever loop you have in your code if you want x, y and z to continue updating, I thought being able to call the update property separately and having them all start with acceleration made it more obvious that they're all related.
I can change it if you'd rather it just be the single property.
There was a problem hiding this comment.
I was thinking it'd be:
x, y, z = cpx.acceleration
Sphinx docs added, conf.py updated, image included.
kattni
force-pushed
the
acceleration-implementation
branch
from
888ac05 to
597cada
Compare
Updated doc to reflect changes.
Sphinx docs added, conf.py updated, image included.