Skip to content

Deprecate temperature #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Deprecate temperature #30

merged 1 commit into from
Jul 15, 2019

Conversation

caternuson
Copy link
Contributor

Hardware support for external thermistor removed by vendor. Remove calls to temperature from example and update docstring.

@ladyada ladyada merged commit 5b40090 into adafruit:master Jul 15, 2019
@Napsty
Copy link

Napsty commented Jul 24, 2019

Hardware support for external thermistor removed by vendor.

@caternuson Do you happen to know the source of this information? Thx

@caternuson
Copy link
Contributor Author

It's in AMS's rev notes for the CCS811:
https://ams.com/documents/20143/36005/CCS811_PN000149_1-00.pdf/
image

Why they did it? I do not know.

@Napsty
Copy link

Napsty commented Jul 25, 2019

@caternuson thx! However the temperature sensor still "kind of works" and shows correct increase and decrease of surrounding temperatures. Here's an example of my sensor currently being in the garage and overnight the temperature dropped until this morning after 9am when it started to rise again.

image

Maybe they removed it from the datasheet to not confuse customers that this sensor can be used to measure real temperature as the temperature is a few degrees too high (probably due to sensor's own heat)? To me the sensor's temperature is a helpful indicator nevertheless.

If someone (like me) still wants to get the temp readings, we should still document the possibility of ccs811.temperature somewhere. Is there a function reference somewhere? Currently ccs.temperature(after ccs = adafruit_ccs811.CCS811(i2c_bus)) is still documented in the README.

@ladyada
Copy link
Member

ladyada commented Jul 25, 2019

old chips have the register working, new chips definitely do not - they return 0 data always. i agree the sensor wasn't great, but having the function is just going to be a total nightmare for support. we'd rather just remove it.

@caternuson
Copy link
Contributor Author

@ladyada I didn't remove the function, just marked it as deprecated. Figured leave it in for boards with the older rev chip. Let me know if you want it totally gone.

I'll make a quick PR for this:

Currently ccs.temperature(after ccs = adafruit_ccs811.CCS811(i2c_bus)) is still documented in the README.

Thanks for spotting that @Napsty

@ladyada
Copy link
Member

ladyada commented Jul 25, 2019

yes sorry, please do keep it marked deprecated but there. can u remove it from the examples if its there?

@caternuson
Copy link
Contributor Author

Yep, took care of examples already. Looks like it was just a few lingering mentions. PR'd in #32

@Napsty
Copy link

Napsty commented Jul 26, 2019

old chips have the register working, new chips definitely do not - they return 0 data always.

Good point. How does the end user know about the chip version? I bought the CCS811 in January this year (2019) and it returns a temperature value.

@ladyada
Copy link
Member

ladyada commented Jul 26, 2019

check the firmware version

@Napsty
Copy link

Napsty commented Jul 26, 2019

check the firmware version

Tell me how and I'll do :)

@ladyada
Copy link
Member

ladyada commented Jul 26, 2019

the registers are described in the datasheet, we dont have code for it specifically

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#37 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#3 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#13 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#12 from s-light/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#36 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#31 from peterhinch/rename-reset

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#34 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#32 from caternuson/minor_tweaks
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#31 from caternuson/fix_lint
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#30 from caternuson/remove_temp

Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#16 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.9.0 from 1.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#67 from brentru/add-get-time

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.0.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#8 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.0.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#11 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.4 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#15 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#18 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#17 from adafruit/revert-16-add-blinka-to-requirements-txt
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#16 from demophoon/add-blinka-to-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#11 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#19 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.1.4 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#13 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#22 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP006 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#5 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.0.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#5 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#25 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.0.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#30 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.7.2 from 1.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#27 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_JWT, Adafruit_CircuitPython_NTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants