Skip to content

Use "address" not "addr" for specifying the I2C address, for consistency with other drivers #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deshipu opened this issue Apr 4, 2018 · 1 comment
Closed

Use "address" not "addr" for specifying the I2C address, for consistency with other drivers #15

deshipu opened this issue Apr 4, 2018 · 1 comment

Comments

@deshipu
Copy link
Contributor

deshipu commented Apr 4, 2018

We need a consistent API between different drivers, and all I2C-based drivers should use the same keywords.
@tannewt
Copy link
Member

tannewt commented Apr 5, 2018

Yes! Totally!

@tannewt tannewt closed this as completed in cdfa594 Apr 5, 2018
tannewt added a commit that referenced this issue Apr 5, 2018
@tannewt
Merge pull request #16 from adafruit/deshipu-patch-1
cd9691a 
fix #15: use "address" keyword for the i2c address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tannewt @deshipu