i2c_device: remove write(stop=), write_then_readinto(stop=) #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any code that uses the stop= kwarg will get an exception at runtime. CircuitPython 5.x and 6.x both have writeto_then_readfrom, as does Blinka. However, this is incompatible with CircuitPython 4. We have previously dropped building the 4.x bundle so this should be OK.
|
repeated my tests from #54 on this PR -- they also work fine. |
dhalbert
approved these changes
Jul 26, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 27, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.1 from 4.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#57 from phil-shenk/issue56 > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#55 from jepler/remove-stop-kwarg2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any code that uses the stop= kwarg will get an exception at runtime. This is the incomptaible alternative compared to #54.
CircuitPython 5.x and 6.x both have writeto_then_readfrom, as does Blinka. However, this is incompatible with CircuitPython 4. We have previously dropped building the 4.x bundle so this should be OK.
The changes ended up being a bit more extensive. Testing performed was creating the accelerometer object on an adafruit clue: