Added debug to i2c_device. #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on Feather M4 with VCNL4040. |
ladyada
requested changes
Feb 8, 2019
adafruit_bus_device/i2c_device.py
Outdated
| @@ -147,10 +152,19 @@ def write_then_readinto(self, out_buffer, in_buffer, *, | |||
| self.i2c.writeto_then_readfrom(self.device_address, out_buffer, in_buffer, | |||
| out_start=out_start, out_end=out_end, | |||
| in_start=in_start, in_end=in_end, stop=stop) | |||
| if self._debug: | |||
| print("i2c_device.writeto_then_readfrom.out_buffer:", [hex(i) for i in out_buffer]) | |||
| print("i2c_device.writeto_then_readfrom.in_buffer:", [hex(i) for i in in_buffer]) | |||
There was a problem hiding this comment.
you need to slice in_start and in_end here, ditto above for out_buffer
adafruit_bus_device/i2c_device.py
Outdated
| else: | ||
| # If we don't have a special implementation, we can fake it with two calls | ||
| self.write(out_buffer, start=out_start, end=out_end, stop=stop) | ||
| if self._debug: | ||
| print("i2c_device.write_then_readinto.write.out_buffer:", | ||
| [hex(i) for i in out_buffer]) |
adafruit_bus_device/i2c_device.py
Outdated
| self.readinto(in_buffer, start=in_start, end=in_end) | ||
| if self._debug: | ||
| print("i2c_device.write_then_readinto.readinto.in_buffer:", | ||
| [hex(i) for i in in_buffer]) |
ladyada
requested changes
Feb 8, 2019
| print("i2c_device.writeto_then_readfrom.in_buffer:", [hex(i) for i in in_buffer]) | ||
| print("i2c_device.writeto_then_readfrom.out_buffer:", | ||
| [hex(i) for i in out_buffer[out_start:out_end]]) | ||
| print("i2c_device.writeto_then_readfrom.in_buffer:", |
There was a problem hiding this comment.
i think print the writebuffer slice before the command, then the readbuffer after.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 9, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.1.2 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#31 from khavik/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#6 from TG-Techie/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.9 from 2.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#24 from kattni/add-debug-to-i2cdevice Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.5.0 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_Register#20 from kattni/bit-bits-16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.