add write_then_readinto support for linux (and possibly others!) #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Aug 17, 2018
adafruit_bus_device/i2c_device.py
Outdated
| @@ -101,6 +101,44 @@ def write(self, buf, **kwargs): | |||
| """ | |||
| self.i2c.writeto(self.device_address, buf, **kwargs) | |||
|
|
|||
| #pylint: disable-msg=too-many-arguments | |||
| def write_then_readinto(self, out_buffer, in_buffer, | |||
There was a problem hiding this comment.
Add a *, after in_buffer, to make the remaining arguments kwarg-only. This way the start and stop numbers must always be "labeled".
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 18, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.4 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#20 from ladyada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we do a fallback if there's no inherent busio support for single-transaction write+read, so should continue to work fine under current micros