Exclude alpha and beta releases #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommersoft
requested changes
Jul 11, 2019
There was a problem hiding this comment.
Oh yeah! Now I remember talking about this in Discord.
However, this won't affect any bundle changes. update-submodules.sh doesn't get run daily like adabot.
I think the proper place to update is here: https://github.com/adafruit/adabot/blob/master/adabot/circuitpython_bundle.py#L149
|
@sommersoft - Aha, I had trouble finding it! Is this still a useful change? I'm not sure when this scripts gets run anymore (maybe never). |
|
I get the feeling that it was the initial bundler/updater, before @tannewt setup Adabot. I don't know of it being used anywhere... |
|
Can we close this? |
|
How about merging this anyway to keep it the same as adabot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173.
Thanks to @sommersoft for working on this with me. It took a lot of trial and error to figure out the right
git rev-listarguments.