Skip to content

Fix pypi install #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Fix pypi install #22

merged 2 commits into from
Jun 24, 2020

Conversation

dhalbert
Copy link
Contributor

This is a multifile package, but setup.py thought it was a single-file module.

@makermelissa This is essentially the same fix you just found for blinka displayio.

@dhalbert dhalbert requested a review from a team June 24, 2020 02:38
@FoamyGuy
Copy link
Contributor

I may have done something incorrectly but I am getting Error upon importing still after attempting to test this fix in the same way I did for Blinka_Displayio repo. I pulled this branch and ran pip3 install . inside the directory. It outputted what seems like successful:

Building wheels for collected packages: adafruit-circuitpython-bluefruitconnect
  Running setup.py bdist_wheel for adafruit-circuitpython-bluefruitconnect ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-dr2zn7hn/wheels/87/72/57/d21f5                                                                                                                                                             835982ca65e3306849502c5b88ffe22a9ed74d26c0447
Successfully built adafruit-circuitpython-bluefruitconnect
Installing collected packages: adafruit-circuitpython-bluefruitconnect
Successfully installed adafruit-circuitpython-bluefruitconnect-0.1.dev65+g6ae038b

But afterward attempting to import I get this error:

>>> from adafruit_bluefruit_connect.color_packet import ColorPacket
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'adafruit_bluefruit_connect'
>>> import adafruit_bluefruit_connect
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'adafruit_bluefruit_connect'

@FoamyGuy
Copy link
Contributor

One more quick note:

Both imports do work correctly if I start the python3 shell inside of this repo's directory. Only after the pip3 install that the imports are not working.

@dhalbert dhalbert requested a review from FoamyGuy June 24, 2020 13:24
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed imports are working correctly for me after pip3 install . with the latest commit.

@dhalbert dhalbert merged commit 1db962e into adafruit:master Jun 24, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 25, 2020
@dhalbert dhalbert deleted the pypi-packages branch June 29, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants