Including exception regarding missing FONTBOUNDINGBOX parameter

[jposada202020]

Including exception regarding missing FONTBOUNDINGBOX parameter in the font file.

Will produce

Exception: Font does not have the FONTBOUNDINGBOX property. Try a different font

Solves #25

[jposada202020]

This was tested manually removing the FONTBOUNDINGBOX line in a bdf font file. Thanks!

[jepler]

If a font can't .get_bounding_box(), are there other uses for it?

If not, why don't we handle this oddity in the constructor instead of here, by rejecting the font when it is first opened.

[jposada202020]

I do not think the font should be used. So answer will be no.

Just for reference: .get_bounding_box() is used in:

bitmap_label

in the _line_spacing_ypixels function

label

To define the height in self.height

Not sure why there is this difference, but I agree with you to handle it in the constructor. Thanks I will work on that and Re-submit

[jposada202020]

@jepler Chages were made. Two things:
A new attribute is created. This way it could be call in the future by the Text libraries (modification will be needed). However would works as you can see in the new get_bounding_box()
We still need to parse the first lines of code and get the value, so I create a new function not to put a lot of lines in the __init__ this is a design choice, but all the code could be done at __init__. Just my preference, open to change if wanted.

[jposada202020]

Hey @jepler , this probably got lost in your inbox, but if you could review the requested changes when you get a chance, that would be great

[jepler]

Thanks! Sorry I let this languish.

[jposada202020]

😃 Thanks