PCF: Fix font metrics of "5x8.pcf" #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, this affected the "5x8.pcf" font, giving an incorrect bounding box.
FoamyGuy
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
I tested this out on:
Adafruit CircuitPython 6.2.0-beta.3-36-g103632f44 on 2021-03-07; Adafruit PyPortal with samd51j20
And confirmed it does resolve the issue with multi-line labels that use the 5x8.pcf font file linked in #38
Looks good to me, thanks for the fix.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.0.0 from 2.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#38 from makermelissa/refactor Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.6 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#40 from jepler/pcfmetrics Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#9 from kmatch98/switch_round Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.3.0 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#19 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#17 from FoamyGuy/pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#18 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #38 -- 5x8.pcf.zip now has metrics
(5, 8, 0, -1), matching the bdf version of the font.This PR also adds some const() declarations and fixes pylint problems in tests/.