Skip to content

Removing 3.0.0 compatibility. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Mar 30, 2020

Fixes #9

Requires testing of bdf.py file.

@kattni kattni requested review from FoamyGuy and a team March 30, 2020 16:00
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error:

Traceback (most recent call last):
  File "code.py", line 10, in <module>
  File "/lib/adafruit_bitmap_font/bitmap_font.py", line 56, in load_font
  File "/lib/adafruit_bitmap_font/bdf.py", line 43, in <module>
ImportError: cannot import name Glyph

Running on PyPortal with 5.0.0 and 5.1.0.rc0.

I will test a few other devices.

@FoamyGuy
Copy link
Contributor

Same results with EdgeBadge and CPB+Gizmo 5.0.0 on both. Can recreate with REPL:

Adafruit CircuitPython 5.0.0 on 2020-03-02; Adafruit Circuit Playground Bluefruit with nRF52840
>>> from displayio import Glyph
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name Glyph

@kattni
Copy link
Contributor Author

kattni commented Mar 31, 2020

@FoamyGuy I may have done this wrong then. I'll take a look tomorrow.

@tannewt
Copy link
Member

tannewt commented Mar 31, 2020

Glyph moved from displayio to fontio so the reverse should work.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Apr 2, 2020

I was not sure how to fix the docs conf on this PR so I've created #21 to resolve it. Let me know if I should do something different.

Tested this changes successfully with the adafruit_display_text simpletest on PyPortal and PyGamer.

@kattni
Copy link
Contributor Author

kattni commented Apr 2, 2020

Closing in favor of #21

@kattni kattni closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove backward-compatible imports when 4.0.0 released
3 participants