Update to CP 10 with busdisplay

[Neradoc]

displayio.Display was deprecated in 9 and removed in 10.

Traceback (most recent call last):
  File "code.py", line 34, in <module>
  File "/lib/adafruit_bitmapsaver.py", line 34, in <module>
ImportError: can't import name Display

This removes compatibility with Circuitpython 8 and earlier.

[FoamyGuy]

Thank you for the fix!

I think adding this in docs/api.rst should fix the actions error. Similar to this one: https://github.com/adafruit/Adafruit_CircuitPython_SSD1681/blob/58e49d44dab693728c1515a8092faa5b9469a869/docs/api.rst?plain=1#L7-L8

API Reference
#############

[FoamyGuy]

Suggested change

	elif not isinstance(pixel_source, BusDisplay):
	elif not isinstance(pixel_source, (BusDisplay, FramebufferDisplay)):

Please add FramebufferDisplay here as well, it hasfill_row() and is supported by this library too.

It will need to import it as well

from framebufferio import FramebufferDisplay

[Neradoc]

Oh I didn't do a local sphinx build. It complained about busdisplay too, it passes now.

I'm actually not a big fan of testing for isinstance and also importing unconditionally. What if a board has busdisplay but not framebufferio ? Like those 30 boards:
https://docs.circuitpython.org/en/latest/shared-bindings/support_matrix.html?filter=busdisplay&filter=-framebufferio

Can we test for hasattr("fill_row") instead ?

[FoamyGuy]

@Neradoc yes, hasattr("fill_row") is good with me. If we change all of the isinstance to hasattr it looks like the only remaining usages of BusDisplay are for type annotations. We could move both BusDisplay and FramebufferDisplay imports into the block guarded by try: import typing so they don't get imported at all when running on mcu.

[Neradoc]

I think it's good now. I tested it on a board with builtin display only though.

[FoamyGuy]

Thank you! This looks good to me.