Skip to content

Annotation and hinting for BitbangIO #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 10, 2022
Merged

Annotation and hinting for BitbangIO #23

merged 8 commits into from
Aug 10, 2022

Conversation

tcfranks
Copy link
Contributor

@tcfranks tcfranks commented Aug 4, 2022

No description provided.

@tcfranks
Copy link
Contributor Author

tcfranks commented Aug 4, 2022

going back to check my pre-commit process

tekktrik
tekktrik requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usages of ReadableBuffer and WriteableBuffer! A few bits of feedback but looks good!

tekktrik
tekktrik requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional things that should help resolve the CI issues.

@tcfranks
Copy link
Contributor Author

tcfranks commented Aug 8, 2022

ok, I've lost all ability to black, pylint, pre-commit locally under windows cmd it appears to be a path problem. under git bash it just fails silently. trying to sort it all out, so debugging the final lint issues may take me a while.

@tcfranks
Copy link
Contributor Author

tcfranks commented Aug 9, 2022

is there an issue with setup.py? this error didn't happen before. I got pylint and black back, and black wanted to reformat adafruit_bitbangio.py, so I with that and the semi clean pylint run (re: question on f-strings) I was hoping it would run.

@tekktrik
Copy link
Member

tekktrik commented Aug 9, 2022

All the libraries underwent migration from using setup.py to using pyproject.toml. You can safely delete setup.py from your branch (and pull in changes from upstream).

@tcfranks
Copy link
Contributor Author

tcfranks commented Aug 9, 2022

All the libraries underwent migration from using setup.py to using pyproject.toml. You can safely delete setup.py from your branch (and pull in changes from upstream).

ok. so if i use typing-extensions it only has to go in requirements.txt? At least that's what it looks like.....

@tekktrik
Copy link
Member

tekktrik commented Aug 9, 2022

Yep yep! That's one of the nice changes - single place for dependencies. Since it's required, requirements.txt is the place!

@tekktrik
Copy link
Member

tekktrik commented Aug 9, 2022

Looks like a newline is missing in requirements.txt!

@tcfranks
Copy link
Contributor Author

well, duh. lesson learned, pylint the .txt file changes if you made any!

tekktrik
tekktrik approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tekktrik tekktrik merged commit 16decd6 into adafruit:main Aug 10, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 11, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c39ffe7)
947d95d 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#8 from tekktrik/dev/add-uv-index

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#23 from tcfranks/main
@tcfranks tcfranks mentioned this pull request Sep 19, 2022
Merged
@tekktrik tekktrik mentioned this pull request Sep 21, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcfranks @tekktrik