Skip to content

for #30, adding type annotations #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

for #30, adding type annotations #42

merged 3 commits into from
May 30, 2023

Conversation

rrahkola
Copy link
Contributor

Note: the BNO08X class property, self._two_ended_sequence_numbers, was initialized with send and receive entries, but was manipulated using integer keys. I simplified this to improve the mypy reporting by removing those initial entries.

@rrahkola rrahkola mentioned this pull request Apr 26, 2023
Closed
42 tasks
@tekktrik tekktrik requested a review from a team April 27, 2023 20:29
@tekktrik tekktrik linked an issue Apr 27, 2023 that may be closed by this pull request
Missing Type Annotations #30
Closed
42 tasks
FoamyGuy
FoamyGuy requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @rrahkola!

I have noted a few changes below that I think would be good to make.

FoamyGuy
FoamyGuy approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit with the tweaks mentioned in prior reviews.

The latest version is looking good to me

@FoamyGuy FoamyGuy merged commit 0b9aa9e into adafruit:main May 30, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 31, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b417f43)
b46c1ce 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.3.0 from 3.2.20:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#39 from somenice/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#42 from rrahkola/dev/add_type_attributes

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 2.5.3 from 2.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#117 from tekktrik/dev/fix-packaging

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.16 from 1.1.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#9 from julianaklulo/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.14.0 from 1.13.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#132 from FoamyGuy/allow_redirects

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@rrahkola @FoamyGuy