Skip to content

bno080x_heading_example #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2021
Merged

bno080x_heading_example #14

merged 3 commits into from
Mar 17, 2021

Conversation

yugyesh
Copy link
Contributor

@yugyesh yugyesh commented Jan 5, 2021

Using rotation vectors to find the heading value

@yugyesh
bno080x_heading_example
8337cdc 
Using rotation vectors to find the heading value
@ladyada
Copy link
Member

ladyada commented Jan 5, 2021

nice! can you run black on your example? that will format it nicely
@kattni can help you if you dont know how

@ladyada ladyada requested a review from kattni January 5, 2021 04:17
@tannewt tannewt mentioned this pull request Jan 5, 2021
Closed
@yugyesh yugyesh closed this Mar 14, 2021
@yugyesh yugyesh reopened this Mar 14, 2021
@yugyesh yugyesh closed this Mar 15, 2021
@kattni
Copy link
Contributor

kattni commented Mar 15, 2021

@yugyesh Do you need assistance running Black on your code? We can't merge it until CI passes, and there are two issues making it fail - one is that you need to run black to format it properly, and two, you need to add licensing info at the top of the file. Please let me know if this is something you're interested in doing. I can assist you over the next couple of days if needed.

@yugyesh
Copy link
Contributor Author

yugyesh commented Mar 16, 2021 via email

@kattni kattni reopened this Mar 16, 2021
@kattni
Copy link
Contributor

kattni commented Mar 16, 2021 •
edited
Loading

Hello @yugyesh! Thank you for your submission, I really appreciate it. I have reopened this PR, so you edit within this PR and it will update.

I'm realising that you may have submitted this through GitHub. Am I correct in thinking that? Did you use this interface to "Add a file" and then submit the PR that way? Please let me know.

I have a Learn guide that explains how to run Black. Please start by reading this: https://learn.adafruit.com/improve-your-code-with-pylint/black

If you have any questions after reading the guide, please post them here.

For licensing, you need to add the following to the top of the file:

# SPDX-FileCopyrightText: 2021 KC YUGESH
# SPDX-License-Identifier: Unlicense

You can change Unlicense to a license of your choice, such as MIT if you wish. Or you can leave it as Unlicense.

@yugyesh
Copy link
Contributor Author

yugyesh commented Mar 17, 2021

Hello @kattni yes I have used the github interface to in order to initiate the pull request. However the suggested changes has been performed using git bash.

Even after formatting using black the check is getting failed

image

kattni
kattni approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yugyesh Thank you! You did everything perfectly! I'm going to merge this.

This failure is unrelated to what you contributed. Your contribution is passing.

@kattni kattni merged commit ea0f05f into adafruit:master Mar 17, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 24, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a6c2669)
8044466 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#19 from adafruit/patch-test
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#14 from yugyesh/patch-3

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#20 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#7 from rpavlik/slim-lut
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#6 from rpavlik/split
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#9 from rpavlik/fix-lut
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.8 from 3.5.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#130 from adafruit/anecdata-patch-2
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#24 from adafruit/REUSE
  > "Increase duplicate code check threshold "
  > Re-added pylint install to build.yml
  > Removed pylint process from github workflow
  > Hardcoded Black and REUSE versions
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#11 from lubarb/setup-edit
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Cycling_Speed_and_Cadence to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Cycling_Speed_and_Cadence#6 from adafruit/pre-commit
  > "Increase duplicate code check threshold "
  > Re-added pylint install to build.yml
  > Removed pylint process from github workflow
  > Hardcoded Black and REUSE versions
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.6.0 from 1.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#18 from kmatch98/icon_palette
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#25 from jposada202020/main
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#24 from kmatch98/touch_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.2.0 from 4.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#62 from jfurcean/add-led-status
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.14.1 from 0.14.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#48 from FoamyGuy/readinto_fallback
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#49 from kmatch98/readinto_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#34 from adafruit/test-lint
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.3.0 from 0.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#19 from adafruit/add-tests
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#18 from adafruit/jepler-rxuart-example
  > "Increase duplicate code check threshold "
@yugyesh yugyesh deleted the patch-3 branch November 25, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yugyesh @ladyada @kattni