Skip to content

Add UART support #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2020
Merged

Add UART support #47

merged 6 commits into from
Apr 24, 2020

Conversation

caternuson
Copy link
Contributor

For #41

BREAKING CHANGE

  • Adds UART support
  • Classes refactored into base and I2C/UART specific subs
  • examples updated

Tested on Itsy M4.

bno_uart_test

Adafruit CircuitPython 5.1.0 on 2020-04-02; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import board
>>> import adafruit_bno055
>>> bno = adafruit_bno055.BNO055_UART(board.UART())
>>> bno.acceleration
(0.12, -0.43, 9.99)
>>> bno.acceleration
(0.06, -8.53, 5.27)
>>> bno.acceleration
(-3.65, 8.36, 1.48)
>>> bno.acceleration
(-8.49, -4.86, -1.55)
>>>

@caternuson caternuson requested a review from a team April 20, 2020 22:07
siddacious
siddacious approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@siddacious siddacious left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

makermelissa
makermelissa requested changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but do you want to create a UART example file?

@caternuson
Copy link
Contributor Author

Yah, probably good idea to have something. How about commented out code in the existing bno055_simpletest.py ?

@makermelissa
Copy link
Collaborator

Yeah, that would work.

makermelissa
makermelissa approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@makermelissa
Copy link
Collaborator

Just needs to be Black formatted and you're good.

@makermelissa
Copy link
Collaborator

Looks good

@madewhatnow
Copy link

Can't wait for the merge!

@caternuson caternuson merged commit ef2deb9 into adafruit:master Apr 24, 2020
@caternuson caternuson mentioned this pull request Apr 24, 2020
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 25, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@ddcf3f0)
b7042df 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.0.0 from 4.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#47 from caternuson/uart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddacious siddacious siddacious approved these changes

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caternuson @makermelissa @madewhatnow @siddacious