Skip to content

resolves #18 Missing Type Annotations #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

resolves #18 Missing Type Annotations #22

merged 3 commits into from
Aug 25, 2022

Conversation

tcfranks
Copy link
Contributor

submitted for review / comment

@tekktrik tekktrik linked an issue Aug 24, 2022 that may be closed by this pull request
Missing Type Annotations #18
Closed
12 tasks
@tekktrik tekktrik requested a review from a team August 24, 2022 03:23
tekktrik
tekktrik requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback below!

@tekktrik tekktrik self-requested a review August 25, 2022 02:04
@tcfranks
Copy link
Contributor Author

resolves #18 :
submitted for re-review of requested changes

tekktrik
tekktrik approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tekktrik tekktrik merged commit 518e59e into adafruit:main Aug 25, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 25, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d1e2132)
112373e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BH1750#7 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.15 from 1.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#22 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.3.0 from 5.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#114 from tekktrik/dev/iterable-io-rework
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.9 from 1.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#16 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#17 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.4.7 from 1.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#15 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 1.3.7 from 1.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#16 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.3.7 from 1.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#18 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.17 from 1.2.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#15 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.1.12 from 2.1.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#13 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.12 from 1.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#10 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik