Add method to disable gas heater #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting either of temperature or heat time to zero will disable Fixes adafruit#63
graeme-winter
force-pushed
the
disable-heater
branch
from
7977cc3 to
53b814f
Compare
|
Is this ready for review? |
|
I'll welcome some review comments, not had a chance to polish though |
|
I'd suggest using |
FoamyGuy
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
I added a commit to tweak this to use None instead of 0.
The change looks good to me.
Thank you @graeme-winter
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 12, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.0 from 3.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#64 from graeme-winter/disable-heater Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting either of temperature or heat time to zero will disable
Fixes #63