Skip to content

Added temperature offset #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Added temperature offset #32

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ded08dd
Added temperature offset
evaherrada Jul 16, 2020
c5c1eda
Formatting
evaherrada Jul 16, 2020
3adfd8a
Moved offset to simpletest
evaherrada Jul 27, 2020
64d2709
Made requested changes to clarify temperature offset
evaherrada Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion examples/bme680_simpletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,13 @@
# change this to match the location's pressure (hPa) at sea level
bme680.sea_level_pressure = 1013.25

# You will usually have to add an offset to account for the temperature of
# the sensor. This is usually around 5 degrees but varies by use. Use a
# separate temperature sensor to calibrate this one.
temperature_offset = -5

while True:
print("\nTemperature: %0.1f C" % bme680.temperature)
print("\nTemperature: %0.1f C" % bme680.temperature + temperature_offset)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw. Parentheses should be surrounding the calculation.

print("\nTemperature: %0.1f C" % (bme680.temperature + temperature_offset))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houmark Good catch! If you could file an issue, it would be greatly appreciated. Or, if you're comfortable submitting a PR, that would be amazing too!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually fixed in a this commit, so nothing more to do here ;)

print("Gas: %d ohm" % bme680.gas)
print("Humidity: %0.1f %%" % bme680.humidity)
print("Pressure: %0.3f hPa" % bme680.pressure)
Expand Down